[tor-bugs] #31494 [Core Tor/Tor]: config refactoring: follow-ups from merged commits

[Tor Bug Tracker & Wiki]

#31494: config refactoring: follow-ups from merged commits
-----------------------------------------+---------------------------------
 Reporter:  nickm                        |          Owner:  nickm
     Type:  task                         |         Status:  accepted
 Priority:  Medium                       |      Milestone:  Tor:
                                         |  0.4.2.x-final
Component:  Core Tor/Tor                 |        Version:
 Severity:  Normal                       |     Resolution:
 Keywords:  network-team-roadmap-august  |  Actual Points:
Parent ID:  #29211                       |         Points:
 Reviewer:                               |        Sponsor:  Sponsor31-must
-----------------------------------------+---------------------------------

Comment (by nickm):

 Replying to [comment:11 teor]:
 > https://trac.torproject.org/projects/tor/ticket/30935#comment:7
 >
 > Do we have tests that read in whole torrc, state, and SR files, then
 write them out again, and make sure they are unchanged?

 That isn't actually guaranteed to work: read+write only preserves the file
 in some cases.  Trivially, it does not preserve comments or spacing.  Less
 trivially, it does not preserve non-semantic option ordering.  I'll try to
 think of another way to test this.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31494#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online