[tor-bugs] #31594 [Core Tor/Tor]: Close all the log fds before aborting

[Tor Bug Tracker & Wiki]

#31594: Close all the log fds before aborting
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.2.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  diagnostics, 042-should, android,    |  Actual Points:  0.5
  macos, 035-backport, 040-backport,             |
  041-backport                                   |
Parent ID:  #31571                               |         Points:  0.3
 Reviewer:  nickm                                |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 Replying to [comment:2 teor]:
 > Hmm, it looks like I forgot a header that Windows needs. I'll fix that
 when I fix everything else.

 fsync() doesn't do what we want here: I should delete most of the last
 commit, and just keep one of the comment changes.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31594#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online