[tor-bugs] #31240 [Core Tor/Tor]: Make confparse able to handle multiple config_format_t objects at once

[Tor Bug Tracker & Wiki]

#31240: Make confparse able to handle multiple config_format_t objects at once
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  nickm
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.2.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  network-team-roadmap-august, asn-    |  Actual Points:  3
  merge dgoulet-merge                            |
Parent ID:  #29211                               |         Points:  3
 Reviewer:  teor                                 |        Sponsor:
                                                 |  Sponsor31-can
-------------------------------------------------+-------------------------
Changes (by dgoulet):

 * status:  merge_ready => needs_revision


Comment:

 PR 1268 is not building for me (gcc-9):

 {{{
 src/test/test_confparse.c: In function ‘test_confparse_reset’:
 src/test/test_confparse.c:613:21: error: passing argument 1 of
 ‘config_reset_line’ from incompatible pointer type [-Werror=incompatible-
 pointer-types]
   613 |   config_reset_line(&test_fmt, tst, "routerset", 0);
       |                     ^~~~~~~~~
       |                     |
       |                     const config_format_t * {aka const struct
 config_format_t *}
 In file included from src/test/test_confparse.c:17:
 ./src/app/config/confparse.h:152:51: note: expected ‘const config_mgr_t *’
 {aka ‘const struct config_mgr_t *’} but argument is of type ‘const
 config_format_t *’ {aka ‘const struct config_format_t *’}
   152 | STATIC void config_reset_line(const config_mgr_t *mgr, void
 *options,
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31240#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online