[tor-bugs] #29818 [Applications/Tor Browser]: adapt #13379 patch for 68esr

Tor Bug Tracker & Wiki blackhole at torproject.org
Sun Sep 1 20:16:58 UTC 2019


#29818: adapt #13379 patch for 68esr
-------------------------------------------------+-------------------------
 Reporter:  mcs                                  |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:  closed
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:  fixed
 Keywords:  tbb-update,ff68-esr,tbb-9.0-must-    |  Actual Points:
  alpha, TorBrowserTeam201908                    |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor44-can
-------------------------------------------------+-------------------------
Changes (by gk):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:5 mcs]:
 > Testing on Windows 10 with both 64-bit and 32-bit Tor Browser builds
 shows that the updater is working and finding its dependent DLLs (things
 "just work" because the DLLs are in the same directory as updater.exe and
 on Windows the updater is not copied to a secondary location before it is
 launched). On Linux, Mozilla's rpath approach works fine. Finally, for
 macOS we included a fix in our rebased #4234 patch; see the
 AppendToLibPath() call here:
 > https://gitweb.torproject.org/tor-
 browser.git/tree/toolkit/xre/nsUpdateDriver.cpp?h=tor-
 browser-68.1.0esr-9.0-1#n731
 >
 > The above is a somewhat long way of saying we can close this ticket.
 Georg, if you agree please resolve this as fixed.

 Looks good to me. Did you know what rstrong meant by saying to add support
 for this ticket on Mozilla's side? Do we need to take some action here
 (see last comment in 1434666)?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29818#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list