[tor-bugs] #31567 [Applications/Tor Browser]: NS_tsnprintf() does not handle %s correctly on Windows

[Tor Bug Tracker & Wiki]

#31567: NS_tsnprintf() does not handle %s correctly on Windows
-------------------------------------------------+-------------------------
 Reporter:  mcs                                  |          Owner:  gk
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Critical                             |     Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-alpha,        |  Actual Points:
  TorBrowserTeam201908                           |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by gk):

 {{{
    int result =
       ReadStrings(path, kUpdaterKeys, kNumStrings, updater_strings,
 "Settings");
 }}}
 causes `result` to be `6` which means `READ_ERROR` and I get garbage back
 for the channel ID. Hrm. Let me try finding out where exactly the reading
 fails. I wonder whether that's another instance of mingw-w64 bugs we need
 to get patched. :/

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31567#comment:27>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online