[tor-bugs] #31567 [Applications/Tor Browser]: NS_tsnprintf() does not handle %s correctly on Windows

[Tor Bug Tracker & Wiki]

#31567: NS_tsnprintf() does not handle %s correctly on Windows
-------------------------------------------------+-------------------------
 Reporter:  mcs                                  |          Owner:  gk
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Critical                             |     Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-alpha,        |  Actual Points:
  TorBrowserTeam201908                           |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by gk):

 Replying to [comment:24 gk]:
 > Replying to [comment:21 mcs]:
 > > Replying to [comment:20 gk]:
 > > > Okay, I got past the cert error just to hit the
 `UPDATE_SETTINGS_FILE_CHANNEL` one. Might be due to my testing setup, hard
 to say from here. What I did was copying the release certs over so that
 they can be used for nightlies as well and then I just did a `make
 nightly-windows-x86_64`.
 > >
 > > I cannot think of a reason why what you did would lead to a failure.
 The `UPDATE_SETTINGS_FILE_CHANNEL` error is generated when the updater
 cannot read and/or parse the file `Browser\update-settings.ini`. The
 contents of that file should look similar on all platforms and for all
 "flavors" of our builds... something like:
 > > {{{
 > > [Settings]
 > > ACCEPTED_MAR_CHANNEL_IDS=torbrowser-torproject-release
 > > }}}
 >
 > Yes, that's what the file in the nightly build contains.

 I looked at the `mar` executable to check what ID actually gets embedded
 during the build process and it show Default `Channel ID: torbrowser-
 torproject-release`. So, this should be fine. I guess the next step is
 finding out what the updater thinks it got for a channel ID.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31567#comment:26>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online