[tor-bugs] #31567 [Applications/Tor Browser]: NS_tsnprintf() does not handle %s correctly on Windows

[Tor Bug Tracker & Wiki]

#31567: NS_tsnprintf() does not handle %s correctly on Windows
-------------------------------------------------+-------------------------
 Reporter:  mcs                                  |          Owner:  gk
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Critical                             |     Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-alpha,        |  Actual Points:
  TorBrowserTeam201908                           |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by gk):

 Replying to [comment:22 mcs]:
 > gk -- hopefully the `UPDATE_SETTINGS_FILE_CHANNEL` error is caused by
 your test setup. However, in case Kathy and I need to do some debugging
 tomorrow, can you tell me how to apply your patch from comment:17 during
 the build? Do I just need to place your patch in
 `projects/mingw-w64-clang/31567.patch`? And will rbm then automatically
 rebuild the mingw-w64-clang project?

 I backported the potential patches Martin provided and am currently
 testing the build in my `bug_31567`. You could use that one if needed.

 I try to look closer into the error I got later today but still hope that
 this is due to us not having proper support for updating nightly builds
 yet.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31567#comment:23>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online