[tor-bugs] #32349 [Core Tor/Tor]: hs-v2: Intro point circuit TIMEOUT failure is not reported

[Tor Bug Tracker & Wiki]

#32349: hs-v2: Intro point circuit TIMEOUT failure is not reported
-------------------------+-------------------------------------------------
     Reporter:  dgoulet  |      Owner:  dgoulet
         Type:  defect   |     Status:  assigned
     Priority:  Medium   |  Milestone:  Tor: 0.4.3.x-final
    Component:  Core     |    Version:
  Tor/Tor                |   Keywords:  035-backport, 040-backport,
     Severity:  Normal   |  041-backport, 042-backport, tor-hs
Actual Points:           |  Parent ID:
       Points:  0.1      |   Reviewer:  asn
      Sponsor:           |
  Sponsor27-can          |
-------------------------+-------------------------------------------------
 This was found while I was working on #32020.

 For v2, we report a TIMEOUT circuit failure within
 `circuit_about_to_free()`. The following code is the snippet on how we
 check if the circuit timed out:

 {{{
 int reason = circ->marked_for_close_reason;
 int timed_out = (reason == END_CIRC_REASON_TIMEOUT);
 }}}

 However, in `circuit_mark_for_close_()`, if the circuit is an origin one,
 which is the case for all HS client circuit, the `marked_for_close_reason`
 is set to `END_CIRC_REASON_NONE` so we don't send back that reason back
 within the destroy cell.

 The fix is that we should be looking at `marked_for_close_orig_reason`
 instead.

 We need to backport this.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32349>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online