[tor-bugs] #32213 [Core Tor/Tor]: Phase 1: Disable minimal dirauth and relay options when those modules are disabled

[Tor Bug Tracker & Wiki]

#32213: Phase 1: Disable minimal dirauth and relay options when those modules are
disabled
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-design, network-team-roadmap-    |  Actual Points:  1.7
  october                                        |
Parent ID:  #31851                               |         Points:  0.5
 Reviewer:  nickm                                |        Sponsor:
                                                 |  Sponsor31-must
-------------------------------------------------+-------------------------
Changes (by nickm):

 * reviewer:  ahf => nickm


Comment:

 Taking review because ahf is busy.  General comments:

  * I like all the code movement here, and I like how clean it looks with
 --color-moved. I look forward to merging this when it's done.
  * Let's see if we can get the coverage on the moved/changed code any
 higher, if that's reasonable?
  * Let's see if we can regenerate practracker in a way that only tightens
 the restrictions on improved files/modules.
  * Some previously static functions have become global.  Not all of them
 have logical prefixes that tie them to a module/type.  Let's do a quick
 audit of these functions, and rename them so that they follow our
 preferred conventions.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32213#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online