[tor-bugs] #32163 [Core Tor/Tor]: Stop using HAVE_MODULE_{DIRAUTH, RELAY} inside functions (was: Stop using HAVE_MODULE_DIRAUTH inside functions)

[Tor Bug Tracker & Wiki]

#32163: Stop using HAVE_MODULE_{DIRAUTH,RELAY} inside functions
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  defect                               |         Status:  new
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-design, network-team-roadmap-    |  Actual Points:
  october                                        |
Parent ID:  #31851                               |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor31-can
-------------------------------------------------+-------------------------

Old description:

> In doc/HACKING/Modules.md, we say that we don't use module macros inside
> functions. But HAVE_MODULE_DIRAUTH is used inside a few functions.
>
> We should stop using HAVE_MODULE_DIRAUTH inside functions, or update the
> documentation to say "avoid using".

New description:

 In doc/HACKING/Modules.md, we say that we don't use module macros inside
 functions. But HAVE_MODULE_DIRAUTH and HAVE_MODULE_RELAY are used inside a
 few functions.

 We should stop using HAVE_MODULE_DIRAUTH and HAVE_MODULE_RELAY inside
 functions, or update the documentation to say "avoid using".

--

Comment (by teor):

 #32213 removes the config.c HAVE_MODULE_DIRAUTH in functions.

 The remaining uses are:
 * routerlist.c
 * subsystem_list.c

 #32162 will remove the HAVE_MODULE_RELAY in functions.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32163#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online