[tor-bugs] #30920 [Core Tor/Tor]: Detect uint64 overflow in config_parse_units()

[Tor Bug Tracker & Wiki]

#30920: Detect uint64 overflow in config_parse_units()
----------------------------------------+----------------------------------
 Reporter:  nickm                       |          Owner:  (none)
     Type:  defect                      |         Status:  needs_revision
 Priority:  Low                         |      Milestone:  Tor:
                                        |  0.4.3.x-final
Component:  Core Tor/Tor                |        Version:
 Severity:  Minor                       |     Resolution:
 Keywords:  easy overflow extra-review  |  Actual Points:  0.2
Parent ID:                              |         Points:
 Reviewer:  teor, nickm                 |        Sponsor:
----------------------------------------+----------------------------------
Changes (by teor):

 * keywords:  easy overflow => easy overflow extra-review
 * reviewer:  teor => teor, nickm


Comment:

 We need to fail on negative multipliers, because the function returns an
 unsigned integer. I've added a suggestion on the pull request.

 Once that is applied, I think we can merge, but I'd like nickm to do a
 final review before we merge,

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30920#comment:33>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online