[tor-bugs] #32131 [Circumvention/Snowflake]: `SetDeadline not implemented` errors in proxy-go output

[Tor Bug Tracker & Wiki]

#32131: `SetDeadline not implemented` errors in proxy-go output
-------------------------------------+-----------------------------
 Reporter:  dcf                      |          Owner:  (none)
     Type:  defect                   |         Status:  merge_ready
 Priority:  Medium                   |      Milestone:
Component:  Circumvention/Snowflake  |        Version:
 Severity:  Normal                   |     Resolution:
 Keywords:                           |  Actual Points:
Parent ID:                           |         Points:
 Reviewer:                           |        Sponsor:
-------------------------------------+-----------------------------
Changes (by dcf):

 * status:  needs_review => merge_ready


Comment:

 Replying to [comment:4 cohosh]:
 > Hmm, actually I just realized the deadline still could serve a purpose
 for the websocket connection to the bridge.

 You're right. I missed that. `CopyLoopTimeout` handles two different types
 of Conn, one that supports a timeout and one that doesn't.

 I haven't come across an actual timeout in this sense... the bridge
 usually closes the websocket connection directly when the OR connection
 closes or times out. Do you know whether this code would ever be needed?

 I agree the timeout is probably unnecessary on the WebSocket connection.
 We don't usually do that timeout thing in our other copy loops. Like
 arlolra says, `CopyLoopTimeout` should then become just `CopyLoop` or
 `copyLoop`.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32131#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online