[tor-bugs] #31130 [Applications/Tor Browser]: Use Debian 10 for our Android container images

[Tor Bug Tracker & Wiki]

#31130: Use Debian 10 for our Android container images
--------------------------------------+--------------------------------
 Reporter:  gk                        |          Owner:  tbb-team
     Type:  defect                    |         Status:  needs_revision
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  tbb-rbm                   |  Actual Points:
Parent ID:  #31127                    |         Points:  0.5
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------------

Comment (by boklm):

 Replying to [comment:16 sisbell]:
 > I can get the following installed correctly in debootstrap-image config.
 I can tell this from the logs. But java doesn't show up in the container
 image when building gradle projects.
 >
 >
 > {{{
 >      apt-get install -y -q ca-certificates-java java-common libcups2
 liblcms2-2 libjpeg8 libfontconfig1 libnss3 libfreetype6 libpcsclite1
 libx11-6 libxext6 libxi6 libxrender1 libxtst6 libglib2.0-0 libxrandr2
 libxinerama1 libgl1-mesa-glx libgtk2.0-0 libatk-wrapper-java-jni libgif7
 libpulse0 isc-dhcp-common
 >      dpkg -i ./openjdk-8-jre-headless.deb
 >      dpkg -i ./openjdk-8-jdk-headless.deb
 >      dpkg -i ./openjdk-8-jre.deb
 >      dpkg -i ./openjdk-8-jdk.deb
 > }}}
 >
 > {{{
 >   - URL:
 http://archive.ubuntu.com/ubuntu/pool/universe/o/openjdk-8/openjdk-8-jre-
 headless_8u232-b09-0ubuntu1_amd64.deb
 >     filename: openjdk-8-jre-headless.deb
 >   - URL:
 http://archive.ubuntu.com/ubuntu/pool/universe/o/openjdk-8/openjdk-8-jre_8u232-b09-0ubuntu1_amd64.deb
 >     filename: openjdk-8-jre.deb
 >   - URL:
 http://archive.ubuntu.com/ubuntu/pool/universe/o/openjdk-8/openjdk-8-jdk_8u232-b09-0ubuntu1_amd64.deb
 >     filename: openjdk-8-jdk.deb
 >   - URL:
 http://archive.ubuntu.com/ubuntu/pool/universe/o/openjdk-8/openjdk-8-jdk-
 headless_8u232-b09-0ubuntu1_amd64.deb
 >     filename: openjdk-8-jdk-headless.deb
 > }}}

 Why are you using Ubuntu packages? We want to use Debian buster, so Ubuntu
 package is not what we should use.

 And the Ubuntu container is only used to run `debootstrap` to create the
 Debian tarballs, so we don't need openjdk there.

 >
 > I tried moving everything above to container-image config but the build
 fails. I'm not sure why there would be a difference.
 >
 > {{{
 > E: Unable to locate package libjpeg8
 > }}}

 Difficult to say without seeing actual patches (I have no idea where you
 added those lines in the `debootstrap-image` and `container-image`
 configs), but maybe you installed the packages in the Ubuntu container in
 the first case, and in the buster container in the second.

 But anyway, as I said in comment:2 and comment:5 we should not do this in
 `debootstrap-image` or `container-image`, but in `rbm.conf` in
 `var/pre_pkginst` (or maybe `var/post_pkginst`). And as we don't want to
 copy the URLs in the `input_files` of all projects, we should download
 them in `var/pre_pkginst` (or `var/post_pkginst`) using wget (followed by
 a sha256sum verification).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31130#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online