[tor-bugs] #31919 [Core Tor/Tor]: Add a check-local target that runs our coccinelle parsing problems script

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri Oct 25 01:13:22 UTC 2019


#31919: Add a check-local target that runs our coccinelle parsing problems script
-----------------------------------+------------------------------------
 Reporter:  teor                   |          Owner:  (none)
     Type:  enhancement            |         Status:  needs_revision
 Priority:  Medium                 |      Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor           |        Version:
 Severity:  Normal                 |     Resolution:
 Keywords:  042-can, extra-review  |  Actual Points:  0.8
Parent ID:                         |         Points:  0.5
 Reviewer:  catalyst               |        Sponsor:
-----------------------------------+------------------------------------
Changes (by catalyst):

 * status:  needs_review => needs_revision
 * reviewer:   => catalyst


Comment:

 I manually tested the pre-commit and pre-push hooks. They seem to work as
 advertised.

 Changes seem reasonable to me by visual inspection.

 There are some whitespace nits in Makefile.am that I commented on in the
 pull request.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31919#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list