[tor-bugs] #31958 [Core Tor/Tor]: connection_dir_is_anonymous: Non-fatal assertion !(CONST_TO_OR_CIRCUIT(circ)->p_chan == NULL) failed

[Tor Bug Tracker & Wiki]

#31958: connection_dir_is_anonymous: Non-fatal assertion
!(CONST_TO_OR_CIRCUIT(circ)->p_chan == NULL) failed
----------------------------------+------------------------------------
 Reporter:  dgoulet               |          Owner:  dgoulet
     Type:  defect                |         Status:  needs_review
 Priority:  Medium                |      Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor          |        Version:
 Severity:  Normal                |     Resolution:
 Keywords:  regression, 042-must  |  Actual Points:  0.1y
Parent ID:  #30344                |         Points:  0.1
 Reviewer:  teor                  |        Sponsor:  Sponsor27-must
----------------------------------+------------------------------------
Changes (by dgoulet):

 * status:  assigned => needs_review
 * reviewer:   => teor
 * points:   => 0.1
 * actualpoints:   => 0.1y


Comment:

 So turns out that the circuit can be marked for close at this stage so the
 fix is to check for that before inspecting the `p_chan` on the circuit. If
 the circuit is _not_ marked for close and the `p_chan` is NULL, then we
 have a problem thus I left the `BUG()` there.

 While having help from Nick, he spotted that the log() are specific to
 HSDir and that is no good. Thus, this branch also changes that.

 Finally, there is a commit to send back a `503` code in case of a single
 hop rejection which I believe is what should be done based on `dir-
 spec.txt` and other similar case in the code.

 PR: https://github.com/torproject/tor/pull/1466
 Branch: `ticket31958_042_01`

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31958#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online