[tor-bugs] #31573 [Applications/Tor Browser]: Uncaught exception in SessionStore.jsm with Tor Browser based on ESR 68

[Tor Bug Tracker & Wiki]

#31573: Uncaught exception in SessionStore.jsm with Tor Browser based on ESR 68
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:
                                                 |  pospeselr
     Type:  defect                               |         Status:
                                                 |  assigned
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ff68-esr, tbb-9.0-issues, tbb-       |  Actual Points:
  regression, tbb-9.0.1-can                      |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by gk):

 Replying to [comment:6 pospeselr]:
 > So this is happening because the {{{dom.push.enabled}}} pref is false,
 so {{{PushComponents.jsm}}} throws {{{NS_ERROR_NOT_AVAILABLE}}} when
 trying to access the {{{PushService}}} singleton. I *think* we can solve
 this by just swallowing the exception, but I need to look through the code
 a bit more to be sure.

 So, this is actually a Firefox bug given that the pref is set to `false`
 [https://searchfox.org/mozilla-
 esr68/source/browser/app/profile/firefox.js#1710 in plain esr68]? If so,
 please file an upstream bug as well and get the patch attached there, too,
 thanks.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31573#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online