[tor-bugs] #32191 [Core Tor/Tor]: when cross-compiling, lzma and zstd will be detected on build system

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Oct 23 22:42:32 UTC 2019


#32191: when cross-compiling, lzma and zstd will be detected on build system
----------------------------------+------------------------------------
 Reporter:  eighthave             |          Owner:  (none)
     Type:  defect                |         Status:  new
 Priority:  Medium                |      Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor          |        Version:
 Severity:  Normal                |     Resolution:
 Keywords:  Android 042-backport  |  Actual Points:
Parent ID:                        |         Points:
 Reviewer:                        |        Sponsor:
----------------------------------+------------------------------------

Comment (by eighthave):

 PKG_CONFIG_SYSROOT_DIR doesn't seem right because it includes the prefix
 e.g. `/usr`. Here's the snipped from the docs:

 "Modify -I and -L to use the directories located in target sysroot. this
 option is usefull when crosscompiling package that use pkg-config to
 determine CFLAGS anf LDFLAGS. -I and -L are modified to point to the new
 system root. this means that a -I/usr/include/libfoo will become
 -I/var/target/usr/include/libfoo with a PKG_CONFIG_SYSROOT_DIR equal to
 /var/target (same rule apply to -L)"

 `export PKG_CONFIG_PATH=$EXTERNAL_ROOT/lib/pkgconfig` has been working in
 the tor-android project.

 About gitlab-ci, I have the `.gitlab-ci.yml` updates already done.  And
 they don't have to be monitored by the network team to be useful.  They'll
 take affect on anyone who has a tor fork in a gitlab instance.  That said,
 gitlab-ci can be set up like Travis-CI and Appveyor in GitHub pull
 requests.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32191#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list