[tor-bugs] #32187 [Core Tor/Tor]: Clean up options_validate() interface

[Tor Bug Tracker & Wiki]

#32187: Clean up options_validate() interface
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  nickm
     Type:  defect        |         Status:  closed
 Priority:  Medium        |      Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:  fixed
 Keywords:                |  Actual Points:  .1
Parent ID:  #31241        |         Points:  .3
 Reviewer:  teor          |        Sponsor:  Sponsor31-can
--------------------------+------------------------------------

Comment (by nickm):

 > Seems fine, where will we make options const?

 Making the "options" argument const will have to happen piece by piece.
 There are a bunch of places where we change it inside options_validate().

 My plan here is: The parent ticket will change the behavior of the
 callbacks, so that the options argument is only non-const in a "legacy"
 verify callback.  As we move verify logic into the new system, we can move
 pieces of it into non-legacy callbacks.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32187#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online