[tor-bugs] #32212 [Applications/Tor Browser]: Tor Browser 9.0 does not restart correctly after updating from 8.5.5, on Debian stretch

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Oct 23 02:20:17 UTC 2019


#32212: Tor Browser 9.0 does not restart correctly after updating from 8.5.5, on
Debian stretch
--------------------------------------+--------------------------
 Reporter:  boklm                     |          Owner:  tbb-team
     Type:  defect                    |         Status:  new
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  tbb-9.0-issues            |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------

Comment (by mcs):

 Replying to [ticket:32212 boklm]:
 > I am wondering if the updater is restarting the browser using
 `Browser/firefox`, or if it is instead running `Browser/firefox.real`
 (without using the wrapper script).

 That is likely true. From code inspection:

 To get the value of the exe arg it passes to the updater, `ApplyUpdate()`
 in `toolkit/xre/nsUpdaterDriver.cpp` calls `XRE_GetBinaryPath()`, which in
 turn calls `mozilla::BinaryPath::GetFile()`.

 From reading `xpcom/build/BinaryPath.h`, on Linux the `GetFile()` call is
 basically  `readlink("/proc/self/exe")` which if I understand things
 correctly will bypass our wrapper script.

 One of us should confirm that this is what is happening, maybe by
 temporarily replacing `updater` with a script that logs its args. Then we
 should think about how to fix this problem.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32212#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list