[tor-bugs] #31549 [Core Tor/Tor]: Authorities should stop listing relays running pre-0.2.9, or running 0.3.0 through 0.3.4

[Tor Bug Tracker & Wiki]

#31549: Authorities should stop listing relays running pre-0.2.9, or running 0.3.0
through 0.3.4
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  nickm
     Type:  enhancement                          |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  042-can 041-backport consider-       |  Actual Points:
  backport-after-authority-test consider-        |
  backport-after-0422 tor-dirauth tor-           |
  bridgeauth                                     |
Parent ID:  #25882                               |         Points:
 Reviewer:  dgoulet, teor                        |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * keywords:
     042-can 041-backport consider-backport-after-authority-test consider-
     backport-after-0423 tor-dirauth tor-bridgeauth
     =>
     042-can 041-backport consider-backport-after-authority-test consider-
     backport-after-0422 tor-dirauth tor-bridgeauth


Comment:

 We tested this on an authority, and it's working fine. There doesn't seem
 much point in testing it in a release. Time to backport.

 Currently:
 * the bridge authority is on 0.3.5
 * 2 authorities are on 0.4.0
 * 6 authorities are on 0.4.1
 * 1 authority is on 0.4.2-alpha
 So we don't need to go any further back than 0.4.1.

 But I want to make a minor fix. In ticket31549_035, we did not backport
 the unit tests. So the header changes are unnecessary, as is the "STATIC"
 on the function, it should just be "static".

 I made these changes in:
 * 0.3.5: https://github.com/torproject/tor/pull/1450

 Anyone can merge to **0.4.1 and later**, after CI passes.

 When merging, we should:
 * do a fixup, to minimise the diff and future conflicts;
 * use `git merge --strategy ours` to merge forward to maint-0.4.2

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31549#comment:31>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online