[tor-bugs] #32108 [Core Tor/Tor]: tor can overrun its accountingmax if it enters soft hibernation first

[Tor Bug Tracker & Wiki]

#32108: tor can overrun its accountingmax if it enters soft hibernation first
-------------------------------------------------+-------------------------
 Reporter:  arma                                 |          Owner:  arma
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.3.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.4.0.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  extra-review consider-backport-      |  Actual Points:
  after-0424 network-health 042-backport         |
  041-backport 040-backport BugSmashFund         |
Parent ID:                                       |         Points:
 Reviewer:  dgoulet, teor                        |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by dgoulet):

 I've brought down my `DormantClientTimeout` as low as I could and I
 confirm that with this patch the `second_elapsed` gets disabled once
 client become dormant. In other words, client still works and goes dormant
 with this patch.

 Then I did a test with a relay with `AccountingMax 10 MB` and very early
 on:

 {{{
 Oct 22 14:36:39.396 [notice] Bandwidth soft limit reached; commencing
 hibernation. No new connections will be accepted
 [...]
 Oct 22 14:36:39.397 [notice] Launching periodic event second_elapsed
 }}}

 And then when it hit full dormant mode, the event is still enabled so
 accounting housekeeping will be executed.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32108#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online