[tor-bugs] #32108 [Core Tor/Tor]: tor can overrun its accountingmax if it enters soft hibernation first

[Tor Bug Tracker & Wiki]

#32108: tor can overrun its accountingmax if it enters soft hibernation first
-------------------------------------------------+-------------------------
 Reporter:  arma                                 |          Owner:  arma
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.3.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.4.0.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  extra-review consider-backport-      |  Actual Points:
  after-0424 network-health 042-backport         |
  041-backport 040-backport BugSmashFund         |
Parent ID:                                       |         Points:
 Reviewer:  dgoulet, teor                        |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by arma):

 Yes, I think that would be fine. Or rather, it needs to call the event
 when net is on, and also when accounting is on. I guess that is what you
 meant by 'only'.

 It would also be reasonable to make a new FL(NEED_NET_ACTUALLY) that
 checks net_is_completely_disabled() rather than net_is_disabled(), and use
 it for that one situation.

 I didn't want to complexify things though.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32108#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online