[tor-bugs] #32181 [Core Tor/Tor]: remove custom Android logging, use syslog

[Tor Bug Tracker & Wiki]

#32181: remove custom Android logging, use syslog
-----------------------+------------------------------
 Reporter:  eighthave  |          Owner:  (none)
     Type:  defect     |         Status:  new
 Priority:  Medium     |      Component:  Core Tor/Tor
  Version:             |       Severity:  Normal
 Keywords:  Android    |  Actual Points:
Parent ID:             |         Points:
 Reviewer:             |        Sponsor:
-----------------------+------------------------------
 As far as I can tell, syslog.h is fully supported for logging to Android's
 logcat.  `syslog.h` is present as early as NDK r10e, if not earlier.  It
 is also included on ''android-9'' (2.3).  My quick tests show syslog
 working fine on ''android-22'' (5.1) through ''android-29'' (10)
 emulators. ''android-24'' (7.0) is currently the oldest version of Android
 supported by Google.  syslog severity and identity tag are already mapped
 to the logcat versions.

 @ahf is there some detail I'm missing?  Were you having problems with
 syslog on Android?

 Since the "android" logging option was never documented, I think it should
 just be removed, long with the `add_android_log()` code that was added in
 #24362
 https://github.com/torproject/tor/commit/b0b8f7c30c8296344c77d06a24821f35b667e3dd

 FYI, since syslog support is added about the same time as logcat support,
 #32036 is still an issue when using syslog with Android.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32181>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online