[tor-bugs] #32108 [Core Tor/Tor]: tor can overrun its accountingmax if it enters soft hibernation first

[Tor Bug Tracker & Wiki]

#32108: tor can overrun its accountingmax if it enters soft hibernation first
-------------------------------------------------+-------------------------
 Reporter:  arma                                 |          Owner:  arma
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.3.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.4.0.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  extra-review consider-backport-      |  Actual Points:
  after-0424 network-health 042-backport         |
  041-backport 040-backport BugSmashFund         |
Parent ID:                                       |         Points:
 Reviewer:  dgoulet, teor                        |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  needs_revision => needs_review
 * reviewer:  dgoulet => dgoulet, teor
 * keywords:  network-health 042-backport 041-backport 040-backport
     BugSmashFund =>
     extra-review consider-backport-after-0424 network-health 042-backport
     041-backport 040-backport BugSmashFund


Comment:

 I think this is the pull request:
 * 0.4.0: https://github.com/torproject/tor/pull/1441

 I think this is a good change, but I'd like dgoulet to also check it.

 Are there any conflicts when it merges forward?

 We have a script for creating test merge forward branches, if you need it:
 https://trac.torproject.org/projects/tor/wiki/org/teams/NetworkTeam/MergeProcess#HowdoweCreateBackportBranches

 Please also open a ticket for the longer-term work:
 > It seems like the immediate fix, and best backport plan, would be to
 resume calling second_elapsed_callback even when net_is_disabled(). The
 longer term plan can be to audit our calls to net_is_disabled() and
 net_is_completely_disabled() and we_are_hibernating(), with an eye towards
 "should we be doing this behavior while soft hibernating", and see what
 other bugs we find.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32108#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online