[tor-bugs] #32108 [Core Tor/Tor]: tor can overrun its accountingmax if it enters soft hibernation first

[Tor Bug Tracker & Wiki]

#32108: tor can overrun its accountingmax if it enters soft hibernation first
-------------------------------------------------+-------------------------
 Reporter:  arma                                 |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.3.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.4.0.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  network-health 042-backport          |  Actual Points:
  041-backport 040-backport BugSmashFund         |
Parent ID:                                       |         Points:
 Reviewer:  dgoulet                              |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by ahf):

 * status:  needs_review => needs_revision


Comment:

 I have said this before and I will repeat it here: in the network team we
 use Github to handle "Pull Requests" for internal people in Tor. It is
 okay to not like Github, but that is what we have chosen to use
 nevertheless. For external people we are very flexible. You are in the
 first category.

 We enforce this for the following reasons:

 Firstly, the Github PR system forces the developer (that is you) to watch
 out for the CI (which happens *before* your code lands and *before* you
 ask anybody to review your code. This is unlike our Jenkins CI which
 happens *after* your code have landed. This allows us to catch bugs
 earl(y|ier) and thus makes the quality of Tor a lot better, which is a
 common goal for all of us, hopefully! We even run upfront CI on both
 Windows and Linux, so we catch quite a lot of things by doing this and
 people work hard on making this experience better, more smooth, and faster
 for everyone.

 Secondly, in the network team we all help with the "coding related
 overhead". We do this by distributing the "boring tasks" that is around
 software development between each other, which ensures that everyone is
 having a reasonably "good time". This only works if *everybody* does the
 overhead work for their own stuff themselves. This includes logging into
 Github, opening a PR to torproject/tor, waiting for the PR to have both
 appveyor and travis go "green". If they don't, you have another iteration
 of your code to do. Once your PR is green, you can change status to
 `needs_review` and a nice person from the network team will happily review
 your code.

 So no matter how small or simple a patch it, it still needs to go through
 the Github system for internal people. If you don't do it, someone else
 from the network team will have to do it for you and that is not fair.

 Please resubmit this as a PR and re-request review again! If you need help
 with doing this, we are very open to helping out. Thanks! :-)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32108#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online