[tor-bugs] #32108 [Core Tor/Tor]: tor can overrun its accountingmax if it enters soft hibernation first

[Tor Bug Tracker & Wiki]

#32108: tor can overrun its accountingmax if it enters soft hibernation first
-------------------------------------------------+-------------------------
 Reporter:  arma                                 |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.3.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.4.0.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  network-health 042-backport          |  Actual Points:
  041-backport 040-backport                      |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by arma):

 * status:  new => needs_review


Comment:

 See my {{{bug32108-option1}}} branch for a fix here. It's based on
 maint-0.4.0 because that's where the bug started.

 (Nick or dgoulet would be good reviewer options because they worked on e.g
 #26064.)

 I call it 'option1' because I am still pondering another approach, where
 we instead make PERIODIC_EVENT_FLAG_NEED_NET check
 net_is_completely_disabled(). That approach looks much harder to audit
 though, and more likely to have weird side effects on the 0.4.0 and 0.4.1
 stables.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32108#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online