[tor-bugs] #32123 [Core Tor/Tor]: Implement minimal --disable-relay-mode

[Tor Bug Tracker & Wiki]

#32123: Implement minimal --disable-relay-mode
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-design, network-team-roadmap-    |  Actual Points:  1.5
  october                                        |
Parent ID:  #31851                               |         Points:  1
 Reviewer:  nickm                                |        Sponsor:
                                                 |  Sponsor31-can
-------------------------------------------------+-------------------------

Comment (by teor):

 Replying to [comment:5 nickm]:
 > Travis is complaining that there is a merge conflict now that #32124 is
 in, but it looks easy enough to resolve.

 It should be a simple rebase.

 > Right now, this will fail silently to start as a relay if the user says
 "ORPort 9000" when the relay module is disabled.  We should prioritize
 that as a next change, since it's a UI problem.

 That's #32139.

 There is also a similar bug in the dirauth module. When it is disabled,
 dirauth options are still accepted, but tor silently launches as a relay
 instead:
 https://github.com/torproject/tor/pull/1421/commits/c32b9f6c795735698a2185ad27a117702ebd55df
 #diff-8e153f33c8af8505093956dfa3a3e131

 I'll do a minimal fix where we disable the essential options. We can
 disable all the options after we've split the air auth and relay options
 out of the main options struct.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32123#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online