[tor-bugs] #31144 [Applications/Tor Browser]: ESR68 Network Code Review

[Tor Bug Tracker & Wiki]

#31144: ESR68 Network Code Review
-------------------------------------------------+-------------------------
 Reporter:  pili                                 |          Owner:  tbb-
                                                 |  team
     Type:  task                                 |         Status:  closed
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:  fixed
 Keywords:  TorBrowserTeam201910R, tbb-9.0       |  Actual Points:
  -must-alpha, tbb-proxy-bypass                  |
Parent ID:                                       |         Points:  10
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:24 sysrqb]:
 > Replying to [comment:23 sysrqb]:
 > > >> CustomTabsActivity.java - Several methods emit potentially external
 Intents
 > > > My only concern here is onLoadRequest() when the scheme isn't
 handled by the browser. That's the only place where the user wasn't
 prompted. I don't know how the customtabs UI should handle this situation.
 We can break this functionality for now, until we find how this should be
 done correctly.
 > >
 > > This is included in the patch for #26529, but in this case we don't
 prompt. #26529 seemed like the better commit, but I can move this into its
 own commit.
 >
 > I pushed `bug31144_05` with only this patch on top of `68.1.0esr-9.0-3`.

 Thanks. I cherry-picked that one on top of `tor-bŕowser-68.1.0esr-9.0-3`
 (commit d5123da897516717e62db98dccbcabd70162dcb3).

 The other commits look good to me and I picked them onto `tor-
 browser-68.1.0esr-9.0-3` (commit 947d477eb9289ebcdbbf48ee77609a6d7f395785,
 47e35494838222732b9eb9638fb40e7a9707b307,
 55b6cd7f3139dd0069ba2c69ec6d08da038594ad,
 dfdef56ec12ace37d08e2df516430427d0e08d7a, and
 db19bbcd9c34c933ad7fc84693ed8a5ad3bac3cf).

 What is missing here is the patch for #26529 which I'll take care in that
 bug. We are done here. \o/

 mikeperrry, sysrqb: please add your points.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31144#comment:25>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online