[tor-bugs] #31999 [Core Tor/Tor]: Default log file is handled inconsistently

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri Oct 18 20:11:10 UTC 2019


#31999: Default log file is handled inconsistently
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  (none)
     Type:  defect        |         Status:  needs_revision
 Priority:  Medium        |      Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:  #31241        |         Points:
 Reviewer:  teor          |        Sponsor:  Sponsor31-can
--------------------------+------------------------------------

Comment (by nickm):

 Our command-line harness can tell what we accept and don't accept, but
 can't tell whether we actually obey the settings properly.  I think this
 is going to need a unit test.  Our existing test_options.c code is pretty
 wonky, but I'll try to come up with something reasonable.

 >It would also be nice to remove unused variables in this ticket:
 >
 >{{{
 >/* 29211 TODO: Remove this from the API. */
 >}}}

 I'd actually like to do this after the next branch I have in mind here,
 where I plan to make the "default_options" variable unused.  After that,
 I'm hoping I can use coccinelle to remove both variables entirely.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31999#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list