[tor-bugs] #32123 [Core Tor/Tor]: Implement minimal --disable-relay-mode

[Tor Bug Tracker & Wiki]

#32123: Implement minimal --disable-relay-mode
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  enhancement                          |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-design, network-team-roadmap-    |  Actual Points:  1.5
  october                                        |
Parent ID:  #31851                               |         Points:  1
 Reviewer:  nickm                                |        Sponsor:
                                                 |  Sponsor31-can
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  assigned => needs_review
 * reviewer:   => nickm
 * actualpoints:   => 1.5


Comment:

 This was a bit more complicated than I expected: a few of our check
 scripts expect relay mode.

 Here's what this PR does:
 0. Depends on the fixes in #32124, to avoid conflicts
 1. Define --disable-module-relay, and make it imply --disable-module-
 dirauth
 2. Disables relay and dircache modes when --disable-module-relay is set
 3. Skips checks that don't work when --disable-module-relay is set
 4. Adds alternative outputs for disable module relay to the parseconf
 checks
   a. Adds extra parseconf checks for dirauth mode, with alternative
 outputs
 5. Adds a CI job for --disable-module-relay
 6. Updates doc/HACKING/Modules.md

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32123#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online