[tor-bugs] #31286 [Applications/Tor Browser]: Include bridge configuration into about:preferences

[Tor Bug Tracker & Wiki]

#31286: Include bridge configuration into about:preferences
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:
                                                 |  pospeselr
     Type:  task                                 |         Status:  closed
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:  fixed
 Keywords:  tbb-9.0-must-alpha, ff68-esr, ux-    |  Actual Points:
  team, TorBrowserTeam201910R                    |
Parent ID:  #10760                               |         Points:  15
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor44-can
-------------------------------------------------+-------------------------
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:42 pospeselr]:
 > I've amended the review4 branch to change the last commit to a fixup!
 commit:
 >
 > tor-browser: tor-browser fixup:
 ​https://gitweb.torproject.org/user/richard/tor-
 browser.git/commit/?h=bug_31286_review4

 Thanks! `git commit --fixup <commitID to fix up>` is what you want next
 time. ;) Othewise `git rebase` has trouble to figure out which commit you
 actually want to fix up. I did that in commit
 569fa462103fdd3547da0a44cffae51b2011b2b6 on `tor-browser-68.1.0esr-9.0-3`.

 > gk: I opted to move the existing strings to the DTD as I gathered from
 acat's changes to securityLevel.js that DTD was what we were using going
 forward (since those strings had originally been in a properties file in
 tor-button).
 >
 > Once tor-launcher is gone and its functionality has been completely
 integrated into Tor Browser (9.5?) then the tor-launcher (and maybe also
 tor-button?) strings can live nicely together in one place in the tor-
 browser repo and the 'TorStrings' module can ''mostly'' go away. I think
 it would make sense to do the string merge at that point.

 Sounds good.

 > Given that new tor bootstrapping UX is going to be coming down the pipe
 soonish, do we need --without-tor-launcher support? What dev scenarios
 does that enable? If so, I'll create a bug to track doing that.

 We can think about that once the plans are a bit more mature. Right now
 the configure switch is useful as we don't build Tor Launcher for mobile
 e.g. as it is not needed there.

 > EDIT: Created #32120 to track the hidden 'Learn More' link

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31286#comment:44>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online