[tor-bugs] #32124 [Core Tor/Tor]: Interpret --disable-module-dirauth=no correctly

[Tor Bug Tracker & Wiki]

#32124: Interpret --disable-module-dirauth=no correctly
-------------------------+-------------------------------------------------
     Reporter:  teor     |      Owner:  teor
         Type:  defect   |     Status:  assigned
     Priority:  Medium   |  Milestone:  Tor: 0.4.3.x-final
    Component:  Core     |    Version:  Tor: 0.3.4.1-alpha
  Tor/Tor                |   Keywords:  network-team-roadmap-october, tor-
     Severity:  Normal   |  build, no-backport?
Actual Points:           |  Parent ID:  #32123
       Points:  0.1      |   Reviewer:
      Sponsor:           |
  Sponsor31-can          |
-------------------------+-------------------------------------------------
 Currently, we treat --disable-module-dirauth=no as enabling the C macro,
 but disabling the Makefile variable.

 Apparently lots of people make this mistake:
 {{{
 The most common mistake for this macro is to consider the two actions as
 action-if-enabled and action-if-disabled.

 This is not the case!

 Since using --disable-foo or --enable-foo=no are equivalent, for the
 macro, you cannot really use this macro with those meanings.
 }}}

 I don't know if we should backport this change, it just didn't work
 before, so maybe it should just go in master?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32124>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online