[tor-bugs] #32072 [Applications/Tor Browser]: Fix Field Name For Tor Binary to Match Orbot
Tor Bug Tracker & Wiki
blackhole at torproject.org
Wed Oct 16 17:56:09 UTC 2019
#32072: Fix Field Name For Tor Binary to Match Orbot
--------------------------------------------+--------------------------
Reporter: sisbell | Owner: tbb-team
Type: defect | Status: new
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: ff68-esr, TorBrowserTeam201910 | Actual Points:
Parent ID: #32069 | Points:
Reviewer: | Sponsor:
--------------------------------------------+--------------------------
Comment (by sisbell):
I think we likely will be just importing the binaries from somewhere. In
the case of tor-browser-build this would come in from the projects/tor
dependency. But yes hard-coding in a Java field is not good. I think we
can pull that version info from file name or some metadata within the
file.
Replying to [comment:3 eighthave]:
> Seems like a good solution would be to do this via the `BuildConfig`
class. In ''build.gradle'', its possible to add things to `BuildConfig`,
then its statically available. So there could be some `BuildConfig` value
based on that `getVersionName()`.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32072#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list