[tor-bugs] #31561 [Core Tor/Tor]: hs-v3: Service can keep unused intro points in its list

[Tor Bug Tracker & Wiki]

#31561: hs-v3: Service can keep unused intro points in its list
---------------------------------------+-----------------------------------
 Reporter:  dgoulet                    |          Owner:  dgoulet
     Type:  defect                     |         Status:  needs_information
 Priority:  Medium                     |      Milestone:  Tor:
                                       |  0.4.2.x-final
Component:  Core Tor/Tor               |        Version:
 Severity:  Normal                     |     Resolution:
 Keywords:  tor-hs, hv-v3, 042-should  |  Actual Points:  0.1
Parent ID:  #30200                     |         Points:  0.2
 Reviewer:  asn, mikeperry             |        Sponsor:  Sponsor27-must
---------------------------------------+-----------------------------------
Changes (by dgoulet):

 * status:  needs_review => needs_information


Comment:

 As per discussion on IRC, Mike spotted that
 `circuit_build_times_handle_completed_hop()` also can timeout a circuit.

 Which means, it would go through `circuit_change_purpose()` and the intro
 point would get retried instead of ditched.

 In other words, we have two different behaviors with this patch with
 regards to the intro circuit:

 1. Time out: intro point is ditched, a new one is picked later.
 2. Closes/Re-purposed: intro point is set as "not established" and then
 will be retried later.

 The change in behavior with this ticket is (1) which makes the service
 ditch an intro point on timeout issues instead of retrying it later.

 I'll delay this one until asn comes back for more discussion.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31561#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online