[tor-bugs] #32063 [Core Tor/Tor]: CID 1454769: Resource leaks in build_establish_intro_dos_extension()

[Tor Bug Tracker & Wiki]

#32063: CID 1454769:  Resource leaks in build_establish_intro_dos_extension()
------------------------------+--------------------------------
     Reporter:  teor          |      Owner:  dgoulet
         Type:  defect        |     Status:  assigned
     Priority:  Medium        |  Milestone:  Tor: 0.4.2.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 Caused by #31682, which was a fix to another coverity issue.

 {{{
 CID 1454769:  Resource leaks  (RESOURCE_LEAK)
 /src/feature/hs/hs_cell.c: 533 in build_establish_intro_dos_extension()
 527
 TRUNNEL_DOS_PARAM_TYPE_INTRO2_BURST_PER_SEC,
 528
 service_config->intro_dos_burst_per_sec);
 529
 530       /* Set the field with the encoded DoS extension. */
 531       ret = trn_cell_extension_dos_encoded_len(dos_ext);
 532       if (BUG(ret <= 0)) {
    CID 1454769:  Resource leaks  (RESOURCE_LEAK)
    Variable "field" going out of scope leaks the storage it points to.
 533         return -1;
 534       })
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32063>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online