[tor-bugs] #31841 [Core Tor/Tor]: test addr/parse takes a long time on master on some machines

[Tor Bug Tracker & Wiki]

#31841: test addr/parse takes a long time on master on some machines
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.4.2.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  unspecified
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-unit-tests 042-should            |  Actual Points:  .2
  BugSmashFund                                   |
Parent ID:                                       |         Points:
 Reviewer:  teor                                 |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  needs_review => merge_ready


Comment:

 This PR seems fine to me.

 There is something consistently broken about the coverage report: we did
 change more than 2 lines.

 It's also worth noting that we are mocking an IPv6-capable resolver, so
 some coverage may change (particularly for IPv4-only cases). But overall,
 coverage will be more stable across environments and network conditions.

 Replying to [comment:18 teor]:
 > "the tests won't hang if your DNS is slow" doesn't really seem like a
 feature.
 > Particularly when I'm the tester, and my builds are incredibly slow.
 >
 > Let's check how far back the 180 addr/parse calls go?
 > I think it's 0.4.2, but it might be 0.4.1.

 I have checked, and I added a large number of address lookups in
 0.4.2.1-alpha, to increase coverage.
 So I don't think we need to backport.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31841#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online