[tor-bugs] #30054 [Community/Translations]: Special characters are not escaped in translations and break the build

[Tor Bug Tracker & Wiki]

#30054: Special characters are not escaped in translations and break the build
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:
                                                 |  emmapeel
     Type:  defect                               |         Status:
                                                 |  needs_information
 Priority:  Medium                               |      Milestone:
Component:  Community/Translations               |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  TorBrowserTeam201904,                |  Actual Points:
  GeorgKoppen201904                              |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by pili):

 This was discussed during the ux team meeting a couple of weeks ago
 (http://meetbot.debian.net/tor-meeting/2019/tor-
 meeting.2019-10-01-13.59.log.html):

 14:32:23 <emmapeel> we have a bot that pulls new translations from
 transifex without any verification. so at some point we should do a
 verification. maybe as part of the pulling from transifex.
 14:32:33 <emmapeel> but anyway we can discuss on the ticket if you have
 any ideas
 14:32:44 <hiro> it should be the bot that does the checks
 14:32:49 <hiro> not git with a hook
 14:33:45 <emmapeel> something called from https://gitweb.torproject.org
 /translation-tools.git/tree/update_translations
 14:34:12 <pili> sounds like this is a discussion that we can maybe take to
 #tor-l10n after? :)
 14:34:29 <pili> I just wanted to make the right people aware of it
 14:34:33 <hiro> sounds like this is not a gitadmin ticket
 14:35:04 <pili> let's move it to the right owner then and discuss it with
 them, does anyone know who that should be?
 14:35:55 <hiro> whoever maintains that bot
 14:36:09 <emmapeel> it is a bit big for me to code a l10n verification
 script in shellscript tbh
 14:36:26 <antonela> maybe bolkm can help us here?
 14:36:33 <emmapeel> i maintain the process of running the bot and make
 little changes, but a verification thing.. uff...
 14:37:27 <pili> which bot is this and where is the code?
 14:38:31 <emmapeel> the code is at https://gitweb.torproject.org
 /translation-tools.git/tree/update_translations and is the bot that pushes
 the transifex updates to https://gitweb.torproject.org/translation.git
 14:39:16 <emmapeel> lives at
 https://db.torproject.org/machines.cgi?host=majus
 14:40:30 <pili> and we think that the bot should check that special
 characters are escaped?
 14:40:45 <hiro> I think python escapes the characters automatically
 nowadays
 14:40:56 <hiro> there should be something called here:
 https://gitweb.torproject.org/translation-
 tools.git/tree/update_translations#n39
 14:41:10 <hiro> before the commits to check if the diff is legit
 14:41:52 <pili> so basically we need a confident bash coder :)
 14:41:59 <emmapeel> the escaping of certain characters on the android
 files is not according to standard, and when adding ' in the translations,
 the build will break. transifex didnt wanted to create a new parsing
 because it is against the escaping rules of dtd files

 We need someone to help emmapeel with this verification script.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30054#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online