[tor-bugs] #31768 [Applications/Tor Browser]: Introduce Tor network settings and other updates in TB9 onboarding

[Tor Bug Tracker & Wiki]

#31768: Introduce Tor network settings and other updates in TB9 onboarding
-------------------------------------------------+-------------------------
 Reporter:  antonela                             |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ux-team, tbb-9.0-must-alpha,         |  Actual Points:
  TorBrowserTeam201910R, tbb-onboarding          |
Parent ID:                                       |         Points:  0.5
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by mcs):

 * status:  needs_revision => needs_review
 * keywords:  ux-team, tbb-9.0-must-alpha, TorBrowserTeam201910, tbb-
     onboarding => ux-team, tbb-9.0-must-alpha, TorBrowserTeam201910R, tbb-
     onboarding


Comment:

 Replying to [comment:38 gk]:
 > Two things I've found while testing:
 >
 > 1) The security item should lose its "New" flag. That feature was new in
 8.5 but is not in 9.0

 Good catch.

 > 2) I think requesting a New Identity should be done via the toolbar
 button, for two reasons: a) we are showing the toolbar + the icon on the
 onboarding card. It seems weird doing that and then using a menuitem
 instead of requesting a New Identity. b) the preferred way of requesting a
 New Identity is likely via the toolbar as this requires less clicks. Thus,
 we should teach the users to use that one instead of the backup option via
 the menu.

 Makes sense. Here is a revised patch:
 https://gitweb.torproject.org/user/brade/tor-
 browser.git/commit/?h=bug31768-02&id=28e7c573ad2c0ffba5eb675447ee0c70a24e1a57

 The New Identity toolbar button highlight is a little subtle. We tried all
 three of the animated methods that the existing Mozilla-derived UITour
 code supports and picked `zoom` because it provides a pulsating effect
 that loops indefinitely. The other two choices are `wobble` which briefly
 rotates the button background and `color` which does not seem to have any
 effect (at least on macOS; it looks like it changes border color).  I
 don't think we have time to do better for TB 9.0, but for future reference
 the animations are defined in here:
 https://searchfox.org/mozilla-
 esr68/source/browser/base/content/browser.css#1281
 and here:
 https://searchfox.org/mozilla-
 esr68/source/browser/base/content/browser.css#1331

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31768#comment:39>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online