[tor-bugs] #31698 [Core Tor/Tor]: Reconsider HAVE_XXX_H usage in the Tor code

[Tor Bug Tracker & Wiki]

#31698: Reconsider HAVE_XXX_H usage in the Tor code
--------------------------+----------------------------------
 Reporter:  ahf           |          Owner:  (none)
     Type:  enhancement   |         Status:  new
 Priority:  Low           |      Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |        Version:  Tor: unspecified
 Severity:  Normal        |     Resolution:
 Keywords:  easy          |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+----------------------------------

Comment (by eighthave):

 ''android/log.h'' is always present when building for Android.  No need to
 test for it, just use it:
 {{{
 #ifdef __ANDROID__
 #include <android/log.h>
 #endif
 }}}

 And `__ANDROID__` is always present, try this with an NDK version since at
 least r10, probably earlier even:

 {{{
 $ for clang in /opt/android-ndk-r20/toolchains/llvm/prebuilt/linux-
 x86_64/bin/*-clang; do printf "%s\t" `basename $clang`; $clang -E -dM - <
 /dev/null | grep __ANDROID__; done
 $ for gcc in /opt/android-ndk-r10e/toolchains/*/prebuilt/*/bin/*-gcc; do
 printf "%s\t" `basename $gcc`; $gcc  -E -dM - < /dev/null | grep
 __ANDROID__; done
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31698#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online