[tor-bugs] #29013 [Applications/Tor Browser]: Provide stack smashing protection for mingw-clang builds

Tor Bug Tracker & Wiki blackhole at torproject.org
Thu Oct 10 14:47:47 UTC 2019


#29013: Provide stack smashing protection for mingw-clang builds
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  enhancement                          |         Status:  closed
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:  fixed
 Keywords:  tbb-rbm, GeorgKoppen201910,          |  Actual Points:  1.5
  tbb-9.0, TorBrowserTeam201910R                 |
Parent ID:                                       |         Points:  1
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by boklm):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 The two patches look good to me. I also checked that a 32bit and 64bit
 build with those two patches are still working for me on a Windows 7 VM.

 I cherry-picked the tor-browser commit as
 `4b8a33af9610111d87dc5a901d06bcc20f1cc7b0`, and merged the tor-browser-
 build commit with `effde40cc5643080d45670d889a2fd81a6d39c67`.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29013#comment:36>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list