[tor-bugs] #31144 [Applications/Tor Browser]: ESR68 Network Code Review

[Tor Bug Tracker & Wiki]

#31144: ESR68 Network Code Review
-------------------------------------------------+-------------------------
 Reporter:  pili                                 |          Owner:  tbb-
                                                 |  team
     Type:  task                                 |         Status:  new
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  TorBrowserTeam201910, tbb-9.0        |  Actual Points:
  -alpha-must                                    |
Parent ID:                                       |         Points:  10
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by gk):

 Replying to [comment:8 gk]:
 > Replying to [comment:7 mikeperry]:
 > > Ok, I'm wrapping this up. I have the following questions/observations
 first:
 > > 1. ./devtools/shared/discovery/discovery.js uses UDP multicast for
 debugger discovery. This should only be local network, but maybe we should
 disable it anyway. Do we?
 >
 > It seems we disabled that via pref (see: comment:7:ticket:18546 and
 comment:10:ticket:16222). We should make sure this still works.
 >
 > > 2. ./dom/presentation/PresentationTCPSessionTransport.cpp seems to use
 TCP for app-to-app communication. Do we disable the DOM presentation
 stuff?
 >
 > We have #18862 for that Arthur checked back then that the prefs are
 disabling everything. They are still set to `false` for desktop. We had
 #22165 as well which got upstreamed meanwhile.
 >
 > I am not exactly sure what we did when Tor Browser on Android entered
 the picture. sysrqb: did you look at that?

 It seems we flipped the prefs there explicitly, so we should be good, I
 guess. sysrqb: I guess that's something we can move to the non-mobile
 specific prefs file as that beast should be disabled for all platforms.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31144#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online