[tor-bugs] #30665 [Applications/Tor Browser]: Get Firefox 68 ESR Working with latest android toolchain

[Tor Bug Tracker & Wiki]

#30665: Get Firefox 68 ESR Working with latest android toolchain
-------------------------------------------------+-------------------------
 Reporter:  sisbell                              |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-rbm, ff68-esr, tbb-9.0-must-     |  Actual Points:
  alpha, TorBrowserTeam201910                    |
Parent ID:  #30324                               |         Points:  2
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor44-can
-------------------------------------------------+-------------------------
Changes (by gk):

 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:22 sisbell]:
 > I verified that we no longer need the armv7 clang.so copy with the
 latest code. Also removed patch from config.
 >
 > https://github.com/sisbell/tor-browser-
 build/commit/24b8dd8a93b4960888cb269446058de711b94b04

 Thanks. I started to look at the other two patches you added. Why do we
 have the `android-packages.patch`? First of all we don't use `android-
 packages.txt` in our build. Then the `doc` package got added because the
 build *required* a network connection before which caused bugs. Thus, we
 should not be affected by having the `doc` package added in our setup
 given that we build offline. So, it seems to me we can drop this patch,
 too. A test build seems to support that.

 Why do we need the other patch? (apart from making the build not break) Is
 there something wrong with how we set up our toolchain? Is that a bug in
 Mozilla's configure code?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30665#comment:23>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online