[tor-bugs] #29698 [Core Tor/Tor]: Edge case that causes improper circuit prioritization for one scheduling run

[Tor Bug Tracker & Wiki]

#29698: Edge case that causes improper circuit prioritization for one scheduling
run
-------------------------------------------------+-------------------------
 Reporter:  pastly                               |          Owner:  dgoulet
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.2.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.2.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-sched, tor-cmux, kist,           |  Actual Points:  0.2
  041-deferred-20190530, 042-should,             |
  BugSmashFund                                   |
Parent ID:                                       |         Points:  0.2
 Reviewer:  nickm                                |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 Looks reasonable; I've left some comments on the patch.

 One more thing I'd request: Could we please have a regression test on
 this?  That is, a test that fails without this patch, and passes with it,
 to demonstrate that we really fixed the problem.

 Also, is this a backport candidate?

 Thanks!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29698#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online