[tor-bugs] #32020 [Core Tor/Tor]: hsv3: Client do not report failing circuit back into HS subsystem

[Tor Bug Tracker & Wiki]

#32020: hsv3: Client do not report failing circuit back into HS subsystem
--------------------------------+--------------------------------
     Reporter:  dgoulet         |      Owner:  (none)
         Type:  defect          |     Status:  new
     Priority:  Medium          |  Milestone:  Tor: 0.4.3.x-final
    Component:  Core Tor/Tor    |    Version:
     Severity:  Normal          |   Keywords:  tor-hs, tor-client
Actual Points:                  |  Parent ID:  #30200
       Points:  1               |   Reviewer:
      Sponsor:  Sponsor27-must  |
--------------------------------+--------------------------------
 This is a subtask of the bigger larger problem in #25882.

 A v2 client does report intro point failures within
 `circuit_about_to_free()` but not v3.

 Actually, any HS circuit client side is not looked at. The
 `hs_circ_cleanup()` was intended for this as the entry point in the HS
 subsystem but only the service uses it.

 Intro circuit failure needs to be noted in the failure cache
 (`hs_cache_client_intro_state_note()`).

 Rendezvous circuit need to be also somehow handled. If the RP circuit
 keeps closing on us, we might want to stop trying maybe?

 Same goes for HSDir circuit, if they close, client needs to be notified
 and launch a refetch.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32020>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online