[tor-bugs] #7164 [Core Tor/Tor]: microdesc.c:378: Bug: microdesc_free() called, but md was still referenced 1 node(s); held_by_nodes == 1

[Tor Bug Tracker & Wiki]

#7164: microdesc.c:378: Bug: microdesc_free() called, but md was still referenced
1 node(s); held_by_nodes == 1
-------------------------------------------------+-------------------------
 Reporter:  jaj123                               |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.4.2.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.4.19
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-client, 025-backport, nickm-     |  Actual Points:
  should-review, review-group-24,                |
  033-triage-20180320, 033-removed-20180320,     |
  042-should, BugSmashFund                       |
Parent ID:                                       |         Points:  2
 Reviewer:  asn                                  |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by dgoulet):

 * cc: nickm (added)
 * keywords:
     tor-client, 025-backport, nickm-should-review, review-group-24,
     033-triage-20180320, 033-removed-20180320
     =>
     tor-client, 025-backport, nickm-should-review, review-group-24,
     033-triage-20180320, 033-removed-20180320, 042-should, BugSmashFund
 * milestone:  Tor: unspecified => Tor: 0.4.2.x-final


Comment:

 `longclaw` saw this yesterday (reported to me in private):

 {{{
 Oct 06 08:20:03.000 [warn] microdesc_cache_clean(): Bug: Microdescriptor
 seemed very old (last listed 192 hours ago vs 168 hour cutoff), but is
 still marked as being held by 1 node(s). I found 1 node(s) holding it.
 Current networkstatus is 0 hours old. Hashtable badness is 0. (on Tor
 0.4.1.6 )
 Oct 06 08:20:03.000 [warn] microdesc_cache_clean(): Bug:   [0]:
 ID=74A910646BCEEFBCD2E874FC1DC997430F968145. md=0x5560fee9d750, rs=(nil),
 ri=0x5560fd45c210. No RS. (on Tor 0.4.1.6 )
 }}}

 FYI, `ID=74A910646BCEEFBCD2E874FC1DC997430F968145` is longclaw's
 fingerprint.

 So I'm assuming this means there is an issue with its own cleanup of its
 md?

 I'm bringing it back to 042 milestone since this seems wise to revisit it
 a bit since it is hitting our dirauth.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7164#comment:110>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online