[tor-bugs] #31747 [Applications/Tor Browser]: Some browser UI is always shown in English

[Tor Bug Tracker & Wiki]

#31747: Some browser UI is always shown in English
-------------------------------------------------+-------------------------
 Reporter:  acat                                 |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ff68-esr tbb-9.0-must-alpha          |  Actual Points:
  TorBrowserTeam201910R, GeorgKoppen201910       |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * keywords:  ff68-esr tbb-9.0-must-alpha TorBrowserTeam201910,
     GeorgKoppen201910 => ff68-esr tbb-9.0-must-alpha
     TorBrowserTeam201910R, GeorgKoppen201910
 * status:  reopened => needs_review


Comment:

 `bug_31747`
 (https://gitweb.torproject.org/user/gk/torbutton.git/commit/?h=bug_31747&id=38712377b6833ae19951ac236e8da83570f3d898)
 has a fix for review. As to what went wrong the theory I have is:
 {{{
 08:56 <+GeKo> i don't think so. i think what happens is that the code
               generating the lang pack is seeing untranslated strings in
 the hg
               repo and putting the english placeholders in it
 08:56 <+GeKo> but you pulling them did not get those
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31747#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online