[tor-bugs] #31607 [Applications/Tor Browser]: App menu items stop working

[Tor Bug Tracker & Wiki]

#31607: App menu items stop working
-------------------------------------------------+-------------------------
 Reporter:  mcs                                  |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:  new
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-alpha,        |  Actual Points:
  TorBrowserTeam201910                           |
Parent ID:                                       |         Points:  0.5
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by mcs):

 After a lot of debugging, Kathy and I learned two things:
 1. The menu-related code in widget/cocoa is fragile and does not recover
 well when things occur in a different order than in Firefox.
 2. The root cause of this bug is that the browser's hidden window is
 created earlier than usual when Tor Launcher is present, and later during
 browser startup that hidden window is replaced with a new one. Some of the
 app menu data structures are associated with the first hidden window and
 they are freed when that hidden window is freed which breaks the app menu
 functionality.

 We found two possible ways to fix this bug:
 (a) Change Tor Launcher to open its wizard/progress window later during
 the startup sequence.
 (b) Change the hidden window creation code inside the guts of the browser
 to not re-create the window.

 Kathy and I believe option (b) is a safer fix. We will post both patches
 so other people can take a look.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31607#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online