[tor-bugs] #31955 [Applications/Tor Browser]: macOS: avoid throwing inside nonBrowserWindowStartup()

[Tor Bug Tracker & Wiki]

#31955: macOS: avoid throwing inside nonBrowserWindowStartup()
-------------------------------------+-------------------------------------
     Reporter:  mcs                  |      Owner:  tbb-team
         Type:  defect               |     Status:  new
     Priority:  Medium               |  Milestone:
    Component:  Applications/Tor     |    Version:
  Browser                            |   Keywords:  TorBrowserTeam201910,
     Severity:  Normal               |  tbb-9.0-must
Actual Points:                       |  Parent ID:
       Points:  1                    |   Reviewer:
      Sponsor:                       |
-------------------------------------+-------------------------------------
 On macOS, opening the Page Info window and other "non browser windows"
 causes a message like this to appear on the Browser Console:
 {{{
 TypeError: document.getElementById(...) is null nonbrowser-mac.js:105:14
 }}}

 This happens because the code inside the nonBrowserWindowStartup()
 function (in browser/base/content/nonbrowser-mac.js) is blindly looking
 for a DOM element that is only present in the Mac hidden window. Kathy and
 I have a patch for this which we should try to upstream to Firefox as
 well.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31955>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online