[tor-bugs] #31934 [Applications/Tor Browser]: Proxy or Kill BaseResource

[Tor Bug Tracker & Wiki]

#31934: Proxy or Kill BaseResource
------------------------------------------+------------------------
     Reporter:  sysrqb                    |      Owner:  tbb-team
         Type:  defect                    |     Status:  new
     Priority:  Very High                 |  Milestone:
    Component:  Applications/Tor Browser  |    Version:
     Severity:  Normal                    |   Keywords:  tbb-mobile
Actual Points:                            |  Parent ID:
       Points:  0.25                      |   Reviewer:
      Sponsor:                            |
------------------------------------------+------------------------
 Mike asked me how we proxy connections from BaseResource. On 60esr, we
 used [https://gitweb.torproject.org/tor-browser.git/commit/?h=tor-
 browser-60.9.0esr-8.5-2&id=cb1bae328e04f7219b0fa9f200cd4815663b5982 a
 patch] for this. That patch was dropped during the rebase becaues I
 incorrectly thought I neutered BaseResource in the
 [https://gitweb.torproject.org/tor-browser.git/commit/mobile/android?h
 =tor-browser-68.1.0esr-9.0-2&id=662ebfc05416d2c0cd7769f864116581a1a78cad
 patch] for #28125.

 I think we're still safe, and we disable all places where BaseResource is
 used, but let's re-land this patch (or we should kill BaseResource
 connections), just so we're more certain the app isn't bypassing the
 proxy.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31934>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online