[tor-bugs] #31652 [Core Tor/Tor]: hs-v3: Service circuit retry limit should not close a valid circuit

[Tor Bug Tracker & Wiki]

#31652: hs-v3: Service circuit retry limit should not close a valid circuit
-------------------------------------------------+-------------------------
 Reporter:  dgoulet                              |          Owner:  neel
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.2.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-hs, tor-circuit, 042-should,     |  Actual Points:
  dgoulet-merge                                  |
Parent ID:  #30200                               |         Points:  0.1
 Reviewer:  asn                                  |        Sponsor:
                                                 |  Sponsor27-must
-------------------------------------------------+-------------------------

Comment (by asn):

 Yes, dgoulet I think you are right.

 Given your feedback I think the behavior before
 https://github.com/torproject/tor/pull/1315/commits/5c26c656a2037f3b264d8c7609621450e6e46293
 is the right one.

 But we need a unittest that **actually** tests this feature.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31652#comment:24>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online